Skip to content

Type projected city object results#346

Merged
esnya merged 2 commits into
mainfrom
codex/type-projected-surface-info
Jun 4, 2026
Merged

Type projected city object results#346
esnya merged 2 commits into
mainfrom
codex/type-projected-surface-info

Conversation

@esnya
Copy link
Copy Markdown
Owner

@esnya esnya commented Jun 1, 2026

Summary

  • make surface projection info represent only projected surfaces with concrete height ranges
  • skip empty surfaces at projection-info creation before facade UV, bottom cull, and generated LOD1 roof selection logic
  • remove nullable height checks and null-forgiving height access from both projection policy paths

Verification

  • dotnet test tests\PlateauResoniteLink.Tests\PlateauResoniteLink.Tests.csproj --configuration Release --no-restore --filter "FullyQualifiedName~CityGmlSurfaceProjectionPolicyTests|FullyQualifiedName~GeneratedLod1RoofCityObjectFactoryTests" --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=false (36 passed)
  • git diff --check
  • dotnet restore PlateauResoniteLink.sln --locked-mode --disable-build-servers
  • dotnet format whitespace . --folder --verify-no-changes
  • dotnet build PlateauResoniteLink.sln --configuration Release --no-restore --disable-build-servers -m:1 -p:UseSharedCompilation=false
  • dotnet test PlateauResoniteLink.sln --configuration Release --no-restore --verbosity normal -m:1 --disable-build-servers -p:UseSharedCompilation=false (1015 passed)
  • Fake Live Sink canonical dump for plateau-13213-higashimurayama-shi-2020, mesh 53395325, packages dem,bldg, terrain mesh grid matched the baseline with git diff --no-index; temp dump removed

@esnya esnya force-pushed the codex/type-raster-metadata-identify-failure branch from a51834e to 0825484 Compare June 2, 2026 15:47
@esnya esnya force-pushed the codex/type-projected-surface-info branch from e7572f8 to 5c8d837 Compare June 2, 2026 15:56
@esnya esnya force-pushed the codex/type-raster-metadata-identify-failure branch from 0825484 to f34ebc9 Compare June 2, 2026 18:24
@esnya esnya force-pushed the codex/type-projected-surface-info branch from 5c8d837 to 0002c7b Compare June 2, 2026 18:24
@esnya
Copy link
Copy Markdown
Owner Author

esnya commented Jun 2, 2026

restack で dynamic terrain projection の runtime geometry cast 除去をこの PR に移しました。surface height range と合わせて、projection 結果を型で持つ境界として review できる単位にしています。\n\n最上位 #356 の tree は restack 前と同一です。検証: restore / format whitespace verify / Release build / Release test (1038 passed)。

@esnya esnya changed the title Require projected surface height ranges Type projected city object results Jun 2, 2026
@esnya esnya force-pushed the codex/type-raster-metadata-identify-failure branch from f34ebc9 to c19cd45 Compare June 2, 2026 19:15
@esnya esnya force-pushed the codex/type-projected-surface-info branch from 0002c7b to 9e62bcb Compare June 2, 2026 19:16
@esnya esnya force-pushed the codex/type-raster-metadata-identify-failure branch from c19cd45 to 07b33fa Compare June 2, 2026 19:34
@esnya esnya force-pushed the codex/type-projected-surface-info branch from 9e62bcb to 3c66bf7 Compare June 2, 2026 19:34
@esnya esnya force-pushed the codex/type-raster-metadata-identify-failure branch from 07b33fa to fd17c3a Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-projected-surface-info branch from 3c66bf7 to b777f50 Compare June 2, 2026 19:59
@esnya esnya force-pushed the codex/type-raster-metadata-identify-failure branch from fd17c3a to 411ad54 Compare June 2, 2026 20:48
@esnya esnya force-pushed the codex/type-projected-surface-info branch from b777f50 to f27f4d2 Compare June 2, 2026 20:48
@esnya esnya changed the base branch from codex/type-raster-metadata-identify-failure to main June 2, 2026 20:49
@esnya esnya merged commit 43a9fbe into main Jun 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant